LGTM now I think. You might want to enable multi instancing support if we need to instance this exporter for every zone. See: https://syn.tools/commodore/reference/architecture.html#_component_instantiation

this is enabled in the exoscale metrics collector but I don't really understand it tbh. Probably because I'm not familiar enough with commodore and our deployment setup. Not sure if @Kidswiss knows more if we need this or not?

@mweibel This change to the metrics collector is so, that each instance will only handle exactly one cluster where the cloudscale appcat services are deployed.

We currently have two clusters where this is the case, appuio cloudscale and appuio exoscale. So in order to get the metrics of all the clusters, we would need two instances of this deployed on the appuio cloudscale cluster (where the database currently lives).

I know that's a rather suboptimal approach, but once we have an actual API for the billing, we can then deploy the collectors to each cluster.

added multi instance - hope that's done the right way?

ah wait, nvm - still need another change.

ok all good now.

after discussion with @zugao we decided to keep image v0.4.1 as the version to deploy for the image and first test the multi instance deployment. This also ensures when merging this and updating it in the catalog, we can test first multi instance deployment and only afterwards the k8s API changes.